Re: [Qemu-devel] [PULL v6 0/3] pci, pc, virtio fixes and cleanups

[Peter Maydell]

On 8 March 2015 at 20:00, Michael S. Tsirkin <address@hidden> wrote:
> An incremental pull update, sent to fix clang warning in v5.
> The following 3 patches added on top:
>     acpi: drop unused code
>     aml-build: comment fix
>     acpi-build: fix typo in comment
> Only tested this lightly, but I checked that gcc generated identical
> stripped object files with and without these patches,
> so should be very safe.
>
> The following changes since commit 11d39a131020cc5c54ff9bc86d3259f7d32bf849:
>
>   Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20150218' into 
> staging (2015-02-26 09:08:54 +0000)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 59ea3e7532a85b15bd551335b27fa97db48efa8d:
>
>   acpi: drop unused code (2015-03-08 11:51:46 +0100)
>
> ----------------------------------------------------------------
> pci, pc, virtio fixes and cleanups
>
> A bunch of fixes all over the place.
> All of ACPI refactoring has been merged.
> Legacy pci commands have been dropped.
> virtio header cleanup
> initial patches from virtio-1.0 branch
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> ----------------------------------------------------------------

Applied, thanks.

I think these changes introduced a new warning in "make check" from
the clang undefined-behaviour sanitizer, but I let it pass since we're
not clean there yet anyhow (and it might have been from a previous
pull where I failed to notice it going by in scroll):

hw/pci/shpc.c:162:27: runtime error: left shift of 1 by 31 places
cannot be represented in type 'int'

Looks like the usual lack of a 'U' qualifier on a constant 1 being
shifted left.

-- PMM