Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

[Chen, Tiejun]

On 2015/3/9 18:17, Wei Liu wrote:
> On Mon, Mar 09, 2015 at 02:45:36PM +0800, Chen, Tiejun wrote:
> [...]
> > > > +                exit (1);
> > > > +            }
> > > > +        } else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) {
> > > > +            if (libxl_gfx_passthru_kind_from_string(buf, 
> > > > &b_info->u.hvm.gfx_passthru_kind)) {
> > >
> > > Ditto.
> > >
> > > > +                fprintf(stderr, "ERROR: invalid value \"%s\" for 
> > > > \"gfx_passthru\"\n",
> > >
> > > Ditto.
> >
> > So,
> >
> > @@ -1959,13 +1959,15 @@ skip_vfb:
> >               } else if (i == 1) {
> >                   libxl_defbool_set(&b_info->u.hvm.gfx_passthru, true);
> >               } else {
> > -                fprintf(stderr, "ERROR: invalid value %ld for
> > \"gfx_passthru\"\n", l);
> > +                fprintf(stderr, "ERROR: invalid value %ld for"
> > +                                " \"gfx_passthru\"\n", l);
> >                   exit (1);
> >               }
> >           } else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) {
> > -            if (libxl_gfx_passthru_kind_from_string(buf,
> > &b_info->u.hvm.gfx_passthru_kind)) {
> > -                fprintf(stderr, "ERROR: invalid value \"%s\" for
> > \"gfx_passthru\"\n",
> > -                        buf);
> > +            if (libxl_gfx_passthru_kind_from_string(buf,
> > + &b_info->u.hvm.gfx_passthru_kind)) {
> > +                fprintf(stderr, "ERROR: invalid value \"%s\" for"
> > +                                " \"gfx_passthru\"\n", buf);
> >                   exit (1);
> >               }
> >               libxl_defbool_set(&b_info->u.hvm.gfx_passthru, false);
>
> Your changes are mangled by your email client. But we don't normally
> split the format string so that it's easier to grep.

Yeah.

> What we normally do is
>
>       fprintf(stderr,
>               "FORMAT STRING",
>              a, b, c);
>
> If format string still treads over 80 column it's fine. We can live
> with that.

Understood.

Thanks
Tiejun