Re: [Qemu-devel] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv

[Michael Tokarev]

10.03.2015 10:15, Gonglei wrote:
> On 2015/3/10 13:54, Michael Tokarev wrote:
>> Don't compare syscall return with -1, use "<0" condition.
>> Don't introduce useless local variables when we already
>> have similar variable
>> Rename local variable to be consistent with other usages
>>
>> Signed-off-by: Michael Tokarev <address@hidden>
>> ---
>>  hw/9pfs/virtio-9p-proxy.c | 12 +++++-------
>>  1 file changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
>> index 59c7445..a01804a 100644
>> --- a/hw/9pfs/virtio-9p-proxy.c
>> +++ b/hw/9pfs/virtio-9p-proxy.c
>> @@ -696,9 +696,9 @@ static ssize_t proxy_preadv(FsContext *ctx, 
>> V9fsFidOpenState *fs,
>>  #ifdef CONFIG_PREADV
>>      return preadv(fs->fd, iov, iovcnt, offset);
>>  #else
>> -    int err = lseek(fs->fd, offset, SEEK_SET);
>> -    if (err == -1) {
>> -        return err;
>> +    int ret = lseek(fs->fd, offset, SEEK_SET);
>> +    if (err < 0)
>> +        return ret;
> 
> The above code fragment is confused.

Sorry I don't understand, can you elaborate please?
Note I haven't changed much in there, just variable
rename and changed the condition within if: s/== -1/< 0/.

(BTW, a code fragment can't be confused, it might be
confusing I think, with a reader being confused.
A confused code is um.. something -- a code who doesn't
know what to do... ;)  Sorry can't resist ;)

Thanks,

/mjt