[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/73] Block patches
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PULL 00/73] Block patches |
Date: |
Tue, 10 Mar 2015 19:00:30 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, 03/10 10:49, Peter Maydell wrote:
> Build failure, Win32:
>
> /home/petmay01/linaro/qemu-for-merges/hw/block/virtio-blk.c: In
> function 'virtio_blk_handle_scsi_req':
> /home/petmay01/linaro/qemu-for-merges/hw/block/virtio-blk.c:200:
> warning: unused variable 'acb'
The variable definition should be moved into #ifdef. Kevin, could you squash
this to "[PULL 09/69] virtio-blk: Check return value of blk_aio_ioctl"?:
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index a2e7684..c12d2eb 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -197,11 +197,11 @@ static int virtio_blk_handle_scsi_req(VirtIOBlockReq *req)
VirtIODevice *vdev = VIRTIO_DEVICE(req->dev);
VirtQueueElement *elem = &req->elem;
VirtIOBlock *blk = req->dev;
- BlockAIOCB *acb;
#ifdef __linux__
int i;
VirtIOBlockIoctlReq *ioctl_req;
+ BlockAIOCB *acb;
#endif
/*
- [Qemu-devel] [PULL 71/73] block/raw-posix: fix launching with failed disks, (continued)
- [Qemu-devel] [PULL 71/73] block/raw-posix: fix launching with failed disks, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 66/73] block/vdi: Add locking for parallel requests, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 67/73] scsi-hd: fix property unset case, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 72/73] iotests: add O_DIRECT alignment probing test, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 64/73] iotests: Remove 006, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 68/73] Add testcase for scsi-hd devices without drive property, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 22/73] qcow2: Helper function for refcount modification, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 73/73] MAINTAINERS: Add jcody as blockjobs, block devices maintainer, Kevin Wolf, 2015/03/09
- [Qemu-devel] [PULL 69/73] sheepdog: Fix misleading error messages in sd_snapshot_create(), Kevin Wolf, 2015/03/09
- Re: [Qemu-devel] [PULL 00/73] Block patches, Peter Maydell, 2015/03/10
- Re: [Qemu-devel] [PULL 00/73] Block patches,
Fam Zheng <=