[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] pcie_aer: fix typos in pcie_aer_inject_erro
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] pcie_aer: fix typos in pcie_aer_inject_error comment |
Date: |
Tue, 10 Mar 2015 15:57:58 +0100 |
On Tue, Mar 10, 2015 at 09:34:58AM +0300, Michael Tokarev wrote:
> 10.03.2015 04:49, Chen Fan пишет:
> > Refer to "PCI Express Base Spec3.0", this comments can't
> > fit the description in spec, so we should fix them.
> >
> > Signed-off-by: Chen Fan <address@hidden>
> > ---
> > hw/pci/pcie_aer.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
> > index 1f4be16..7ca077a 100644
> > --- a/hw/pci/pcie_aer.c
> > +++ b/hw/pci/pcie_aer.c
> > @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject
> > *inj, bool is_fatal)
> > * non-Function specific error must be recorded in all functions.
> > * It is the responsibility of the caller of this function.
> > * It is also caller's responsibility to determine which function should
> > - * report the rerror.
> > + * report the error.
> > *
> > * 6.2.4 Error Logging
> > - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations
> > - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and
> > Logging
> > + * 6.2.5 Sequence of Device Error Signaling and Logging Operations
> > + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and
> > Logging
> > * Operations
>
> this 6-2 is not a table, it is "Figure 6-2" on page 479, unless, ofcourse,
> you mean
> "Table 6-2: General PCI Express Error List" on page 481.
>
> I can fix this when applying.
>
> Thanks,
>
> /mjt
OK so you want to take all 3 patches?
> > */
> > int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err)
> >
- [Qemu-devel] [PATCH 0/3] fix pci related code typos, Chen Fan, 2015/03/09
- [Qemu-devel] [PATCH 2/3] aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register, Chen Fan, 2015/03/09
- [Qemu-devel] [PATCH 3/3] pci: fix several trivial typos in comment, Chen Fan, 2015/03/09
- Re: [Qemu-devel] [PATCH 0/3] fix pci related code typos, Chen Fan, 2015/03/09
- Re: [Qemu-devel] [PATCH 0/3] fix pci related code typos, Michael S. Tsirkin, 2015/03/10