[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] target-arm: convert check_ap to get_rw_prot
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/5] target-arm: convert check_ap to get_rw_prot |
|
Date: |
Tue, 10 Mar 2015 15:17:20 +0000 |
On 10 March 2015 at 15:07, Peter Maydell <address@hidden> wrote:
> Given that the 'ap' parameter isn't just the AP bits this
> could use a mention in the comment:
>
> /* Translate section/page access permissions to page
> * R/W protection flags. The 'ap' parameter is the concatenation
> * of the APX:AP bits (with APX zero for the descriptor formats
> * which don't have it).
> */
Ignore this -- "APX" is an ARMv6-ism, and that bit is just
AP[2] in v7 and up.
-- PMM