[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] vnc: remove dead code
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] vnc: remove dead code |
Date: |
Wed, 11 Mar 2015 09:59:14 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/3/10 19:18, Gerd Hoffmann wrote:
> If vs->ws_enabled is set ws_display is non-NULL.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> ui/vnc.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
Reviewed-by: Gonglei <address@hidden>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 65ba1c0..bac44ce 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3627,13 +3627,8 @@ void vnc_display_open(const char *id, Error **errp)
> }
> #ifdef CONFIG_VNC_WS
> if (vs->ws_enabled) {
> - if (ws_display) {
> - vs->lwebsock = inet_listen(ws_display, NULL, 0,
> - SOCK_STREAM, 0, errp);
> - } else {
> - vs->lwebsock = inet_listen(display, NULL, 0,
> - SOCK_STREAM, 5700, errp);
> - }
> + vs->lwebsock = inet_listen(ws_display, NULL, 0,
> + SOCK_STREAM, 0, errp);
> if (vs->lwebsock < 0) {
> if (vs->lsock) {
> close(vs->lsock);
>