[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be in
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t |
Date: |
Wed, 11 Mar 2015 11:32:25 +0000 |
On 13 February 2015 at 06:21, Richard Henderson <address@hidden> wrote:
> On 02/06/2015 06:02 AM, Peter Maydell wrote:
>> The documentation for sextract64() claims that the return type is
>> an int64_t, but the code itself disagrees. Fix the return type to
>> conform to the documentation and to bring it into line with
>> sextract32(), which returns int32_t.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> I quickly eyeballed all the callers and I don't think any of them
>> were relying on the unsignedness of the return type.
>> ---
>> include/qemu/bitops.h | 2 +-
>
> Reviewed-by: Richard Henderson <address@hidden>
>
> Via trivial?
I guess I forgot to cc trivial there. I can just put it in the
ARM pullreq I'm doing anyway I suppose...
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t,
Peter Maydell <=