[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value |
|
Date: |
Wed, 11 Mar 2015 12:39:50 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 12/02/2015 07:21, Yik Fang wrote:
> The value of reply.error should be the type unsigned int.
>
> Signed-off-by: Yik Fang <address@hidden>
> ---
> nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
> default:
> LOG("invalid request type (%u) received", request.type);
> invalid_request:
> - reply.error = -EINVAL;
> + reply.error = EINVAL;
> error_reply:
> if (nbd_co_send_reply(req, &reply, 0) < 0) {
> goto out;
>
Applied to my local branch, thanks.
Paolo