Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

[Michael S. Tsirkin]

On Wed, Mar 11, 2015 at 09:13:18PM +1100, Alexey Kardashevskiy wrote:
> Hi!
> 
> This particular patch broke virtio-scsi in SLOF (ppc64-server firmware),
> QEMU just exits:
> 
> Populating /address@hidden/address@hidden
>        SCSI: Looking for devices
> qemu-system-ppc64: wrong size for virtio-scsi headers
> 
> 
> This is how I run it:
> 
> -device virtio-scsi-pci,id=id3 \
> -drive id=id4,if=none,file=virtimg/rhel7_24GB.qcow2 \
> -device scsi-disk,id=id5,drive=id4
> 
> It is bigendian, kvm or tcg.
> 
> 
> Any quick idea? Thanks :)


Can you please try this patch:
mid.gmane.org/address@hidden

Thanks!

> 
> 
> On 02/16/2015 10:36 PM, Michael S. Tsirkin wrote:
> >On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote:
> >>
> >>
> >>On 15/02/2015 12:39, Michael S. Tsirkin wrote:
> >>>Drop duplicated code.
> >>>
> >>>Signed-off-by: Michael S. Tsirkin <address@hidden>
> >>>---
> >>>  include/hw/virtio/virtio-scsi.h | 120 
> >>> +++-------------------------------------
> >>>  hw/scsi/virtio-scsi.c           |   1 +
> >>>  2 files changed, 10 insertions(+), 111 deletions(-)
> >>>
> >>>diff --git a/include/hw/virtio/virtio-scsi.h 
> >>>b/include/hw/virtio/virtio-scsi.h
> >>>index bf17cc9..9bcda7e 100644
> >>>--- a/include/hw/virtio/virtio-scsi.h
> >>>+++ b/include/hw/virtio/virtio-scsi.h
> >>>@@ -14,6 +14,7 @@
> >>>  #ifndef _QEMU_VIRTIO_SCSI_H
> >>>  #define _QEMU_VIRTIO_SCSI_H
> >>>
> >>>+#include "standard-headers/sys/virtio_scsi.h"
> >>
> >>Why sys/?  It's linux/, let's keep it linux/.
> >>
> >>Paolo
> >
> >Peter requested this change: he felt having portable
> >headers under linux/ is confusing:
> >
> >http://mid.gmane.org/address@hidden
> >
> >Makes sense?
> >
> 
> 
> -- 
> Alexey