qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd
Date: Wed, 11 Mar 2015 15:14:04 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 11/03/2015 15:13, Michael S. Tsirkin wrote:
> The anonymous struct only has a single field now, drop the wrapper
> structure.
> 
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  include/hw/virtio/virtio-scsi.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index e3f27a6..f93b57d 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -134,9 +134,7 @@ typedef struct VirtIOSCSIReq {
>          VirtIOSCSIEvent       event;
>      } resp;
>      union {
> -        struct {
> -            VirtIOSCSICmdReq  cmd;
> -        } QEMU_PACKED;
> +        VirtIOSCSICmdReq      cmd;
>          VirtIOSCSICtrlTMFReq  tmf;
>          VirtIOSCSICtrlANReq   an;
>      } req;
> 

Acked-by: Paolo Bonzini <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]