Re: [Qemu-devel] [PATCH v2 2/3] target-arm: fix get_phys_addr_v6/SCTLR_AFE access check

[Peter Maydell]

On 10 March 2015 at 21:06, Andrew Jones <address@hidden> wrote:
> Introduce simple_ap_to_rw_prot(), which has the same behavior as
> ap_to_rw_prot(), but takes the 2-bit simple AP[2:1] instead of
> the 3-bit AP[2:0]. Use this in get_phys_addr_v6 when SCTLR_AFE
> is set, as that bit indicates we should be using the simple AP
> format.
>
> It's unlikely this path is getting used. I don't see CR_AFE
> getting used by Linux, so possibly not. If it had been, then
> the check would have been wrong for all but AP[2:1] = 0b11.
> Anyway, this should fix it up, in case it ever does get used.
>
> Signed-off-by: Andrew Jones <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM