[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] AHCI: avoid mapping stale gues
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] AHCI: avoid mapping stale guest memory |
Date: |
Thu, 12 Mar 2015 13:49:12 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Mar 10, 2015 at 05:29:02PM -0400, John Snow wrote:
> Currently, the AHCI device tries to re-map guest memory every time
> the low or high address registers are written to, whether or not the
> AHCI device is currently active. If the other register has stale
> information in it, this may lead to runtime failures.
>
> Reconfigure the AHCI device to ignore writes to these registers while
> the device is active, and otherwise postpone the dma memory map until
> the device becomes active.
>
> John Snow (2):
> AHCI: Do not (re)map FB/CLB buffers while not running
> AHCI: Protect cmd register
>
> hw/ide/ahci.c | 61
> ++++++++++++++++++++++++++++++++++++++++++++---------------
> hw/ide/ahci.h | 2 ++
> 2 files changed, 48 insertions(+), 15 deletions(-)
By the way, despite the compiler warning and my comment, I'd like to get
a fix into QEMU 2.3.
I'll be away Friday 13th and Monday 16th of March, so please go ahead
without me. Kevin could review.
Stefan
pgpplbqNlSVvU.pgp
Description: PGP signature