Re: [Qemu-devel] [PATCH 0/2] ahci: test varying sector offsets

[John Snow]

NACK. Patchew caught a problem with how I was generating the QEMU_IMG 
path. Not important for 2.3, anyway.

Will re-spin with a 2.4 subject.

--js

On 03/10/2015 01:29 PM, John Snow wrote:
> This is a re-send of patches 7 & 8 from an earlier series,
> "[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced
> back because I used some glib functions that were too new.
>
> This is effectively v3 of these two patches:
>
> - Removed "./" from the execution CLI. Now you can set an absolute or
>    relative path for QTEST_QEMU_IMG and it will work either way. The default
>    as generated by the Makefile will be a relative path.
>
> - Removed the g_spawn_check_exit_status glib call from mkimg(). See the
>    in-line comments in patch 1/2 for correctness justification.
>
> John Snow (2):
>    qtest/ahci: add qcow2 support to ahci-test
>    qtest/ahci: test different disk sectors
>
>   tests/Makefile        |  1 +
>   tests/ahci-test.c     | 84 +++++++++++++++++++++++++++++++++++++--------------
>   tests/libqos/ahci.c   | 10 +++---
>   tests/libqos/ahci.h   |  4 +--
>   tests/libqos/libqos.c | 41 +++++++++++++++++++++++++
>   tests/libqos/libqos.h |  2 ++
>   6 files changed, 113 insertions(+), 29 deletions(-)