Re: [Qemu-devel] [PULL v4 00/11] Net patches

[Stefan Hajnoczi]

On Thu, Mar 12, 2015 at 3:03 PM, Peter Maydell <address@hidden> wrote:
> On 12 March 2015 at 14:43, Peter Maydell <address@hidden> wrote:
>> On 12 March 2015 at 14:33, Stefan Hajnoczi <address@hidden> wrote:
>>> v4:
>>>  * Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter]
>>>
>>> v3:
>>>  * Add clang 3.5.0 warning fixes
>>>  * Squash David Ahern's clang struct definition warnings fix
>>>
>>> v2:
>>>  * Squash in Jiri's fix for rocker format string specifiers [Peter]
>>>  * Squash in Windows build fix [Peter]
>>>  * Both build fixes are described in "rocker: add new rocker switch device"
>>>
>>> The following changes since commit ee74801035b0b5f1fdfd4e31d3a53f511f91c804:
>>>
>>>   Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150311' into 
>>> staging (2015-03-11 18:22:15 +0000)
>>>
>>> are available in the git repository at:
>>>
>>>   git://github.com/stefanha/qemu.git tags/net-pull-request
>>>
>>> for you to fetch changes up to 8d3f4f565fb4adf940a8824882a7f549304f34fd:
>>>
>>>   rocker: timestamp on the debug logs helps correlate with events in the VM 
>>> (2015-03-12 14:18:11 +0000)
>>
>> w32 build failure :-(
>>
>> cc1: warnings being treated as errors
>> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c: In
>> function 'rocker_io_readq':
>> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:1109:
>> warning: integer constant is too large for 'long' type
>>
>> (64 bit constant without ULL suffix.)
>
> Also fails to build with our minimum glib version:
>
> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:
> In function 'of_dpa_init':
> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273:
> error: 'g_int64_hash' undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273:
> error: (Each undeclared identifier is reported only once
> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273:
> error: for each function it appears in.)
> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273:
> error: 'g_int64_equal' undeclared (first use in this function)
>
> (Both first introduced in glib 2.22.)

Hi Fam,
This pull request contains patches that fail mingw compilation and
glib version requirements.  They passed in patchew:
http://qemu.patchew.org/testing/log/address@hidden

Peter's build script is here:
https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/remake-merge-builds

It would be great to add build environments from Peter's script so
that patchew can flag patches that will fail.

Any thoughts?  Do you need help with that?

Stefan