[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/4] migration: Convert 'status' of Migration
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/4] migration: Convert 'status' of MigrationInfo to use an enum type |
Date: |
Thu, 12 Mar 2015 13:37:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/09/2015 12:45 AM, zhanghailiang wrote:
> The original 'status' is an open-coded 'str' type, convert it to use an
> enum type.
> This conversion is backwards compatible, better documented and
> more convenient for future extensibility.
>
> In addition, Fix a typo for qapi-schema.json (just remove the typo) :
> s/'completed'. 'comppleted' (since 1.2)/'completed' (since 1.2)
>
> Signed-off-by: zhanghailiang <address@hidden>
> ---
> hmp.c | 7 ++++---
> migration/migration.c | 20 +++++---------------
> qapi-schema.json | 34 +++++++++++++++++++++++++++++-----
> 3 files changed, 38 insertions(+), 23 deletions(-)
>
> -enum {
> - MIGRATION_STATUS_FAILED = -1,
> - MIGRATION_STATUS_NONE,
Note that we are changing any 0-initialized struct from having
STATUS_NONE...
> +##
> +{ 'enum': 'MigrationStatus',
> + 'data': [ 'failed', 'none', 'setup', 'cancelling', 'cancelled',
> + 'active', 'completed' ] }
...to now having status _FAILED. Fortunately, in migration/migration.c
(the only caller prior to this conversion), I didn't spot any
zero-initialization (migrate_get_current() returns a struct that is
explicitly initialized to _NONE). So it looks correct.
> +
> ##
> # @MigrationInfo
> #
> # Information about current migration process.
> #
> -# @status: #optional string describing the current migration status.
> -# As of 0.14.0 this can be 'setup', 'active', 'completed', 'failed'
> or
> -# 'cancelled'. If this field is not returned, no migration process
> +# @status: #optional @MigState describing the current migration status.
s/MigState/MigrationStatus/
> + 'data': {'*status': 'MigrationStatus', '*ram': 'MigrationStats',
> '*disk': 'MigrationStats',
Hmm. "Status" and "Stats" look awfully close to one another. But I can
live with the two names (it's not worth a respin just for the rename).
With the typo fix pointed out in the documentation,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type, zhanghailiang, 2015/03/09
- [Qemu-devel] [PATCH v4 4/4] migration: Expose 'cancelling' status to user, zhanghailiang, 2015/03/09
- [Qemu-devel] [PATCH v4 3/4] migration: Convert 'status' of MigrationInfo to use an enum type, zhanghailiang, 2015/03/09
- Re: [Qemu-devel] [PATCH v4 3/4] migration: Convert 'status' of MigrationInfo to use an enum type,
Eric Blake <=
- [Qemu-devel] [PATCH v4 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_*, zhanghailiang, 2015/03/09
- [Qemu-devel] [PATCH v4 2/4] hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus', zhanghailiang, 2015/03/09
- Re: [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type, zhanghailiang, 2015/03/11