Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

[Ting Wang]

On 2015-3-12 22:03, Stefan Hajnoczi wrote:
> On Thu, Mar 12, 2015 at 04:35:24PM +0800, Ting Wang wrote:
>> +void hmp_info_iothreads(Monitor *mon, const QDict *qdict)
>> +{
>> +    IOThreadInfoList *head = NULL, *elem = NULL;
>> +
>> +    head = qmp_query_iothreads(NULL);
>> +    if (!head) {
>> +        monitor_printf(mon, "No iothread has been added\n");
>> +        return;
>> +    }
>> +
>> +    elem = head;
>> +    while (elem) {
>> +        if (elem->value) {
>> +            monitor_printf(mon, "%s: thread_id=%ld\n", elem->value->id, 
>> +                    elem->value->thread_id);
> 
> %ld does not work on 32-bit hosts or 64-bit Windows hosts where long is
> 32-bit.
> 
> Please use the PRId64 format specifier macro for the int64_t thread_id.
> 
OK, I will fix it.

Thank you very much.

Ting