[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity |
Date: |
Sun, 15 Mar 2015 15:11:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 15/03/2015 11:23, Michael Tokarev wrote:
> Or, alternatively, to keep this `data' pointer in sdp to use it in
> bt_l2cap_sdp_close_ch().
Yes.
>> > In any case, it seems simpler to just leave this code aside.
> How many times this code is called?
>
> We have many many places in qemu where resources are allocated once
> at startup and never freed just because there's no need to.
Well, in this case the bug in bt_l2cap_sdp_close_ch is much worse than a
resource leak. But bluetooth is not the utmost priority in QEMU
development...
Paolo