Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak

[Shannon Zhao]

On 2015/3/16 9:27, zhanghailiang wrote:
> On 2015/3/14 17:52, Shannon Zhao wrote:
>> It's detected by coverity. Close the dirfd.
>>
> 
> Reviewed-by: zhanghailiang <address@hidden>
> 

Hi zhanghailiang,

Thanks for your review.

Shannon

>> Signed-off-by: Shannon Zhao <address@hidden>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> ---
>>      v1->v2: close after use [Stefan Weil]
>> ---
>>   qga/commands-posix.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>> index d5bb5cb..ba8de62 100644
>> --- a/qga/commands-posix.c
>> +++ b/qga/commands-posix.c
>> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo 
>> *qmp_guest_get_memory_block_info(Error **errp)
>>
>>       buf = g_malloc0(20);
>>       ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
>> +    close(dirfd);
>>       if (local_err) {
>>           g_free(buf);
>>           error_propagate(errp, local_err);
>>
> 
> 
> 
> .
>