[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/6] virtfs-proxy: Fix possible overflow
From: |
Aneesh Kumar K.V |
Subject: |
[Qemu-devel] [PATCH 5/6] virtfs-proxy: Fix possible overflow |
Date: |
Mon, 16 Mar 2015 15:39:42 +0530 |
From: Shannon Zhao <address@hidden>
It's detected by coverity. The socket name specified
should fit in the sockadd_un.sun_path. If not abort.
Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>
---
fsdev/virtfs-proxy-helper.c | 1 +
hw/9pfs/virtio-9p-proxy.c | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index bf2e5f333121..13fe032543bc 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -738,6 +738,7 @@ static int proxy_socket(const char *path, uid_t uid, gid_t
gid)
return -1;
}
+ g_assert(strlen(path) < sizeof(proxy.sun_path));
sock = socket(AF_UNIX, SOCK_STREAM, 0);
if (sock < 0) {
do_perror("socket");
diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
index 6bb191ee6ab8..71b6198bbd22 100644
--- a/hw/9pfs/virtio-9p-proxy.c
+++ b/hw/9pfs/virtio-9p-proxy.c
@@ -1100,6 +1100,10 @@ static int connect_namedsocket(const char *path)
int sockfd, size;
struct sockaddr_un helper;
+ if (strlen(path) >= sizeof(helper.sun_path)) {
+ fprintf(stderr, "Socket name too large\n");
+ return -1;
+ }
sockfd = socket(AF_UNIX, SOCK_STREAM, 0);
if (sockfd < 0) {
fprintf(stderr, "failed to create socket: %s\n", strerror(errno));
--
2.1.0
- [Qemu-devel] [PULL] VirtFS update, Aneesh Kumar K.V, 2015/03/16
- [Qemu-devel] [PATCH 5/6] virtfs-proxy: Fix possible overflow,
Aneesh Kumar K.V <=
- [Qemu-devel] [PATCH 3/6] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access, Aneesh Kumar K.V, 2015/03/16
- [Qemu-devel] [PATCH 1/6] 9pfs-local: simplify/optimize local_mapped_attr_path(), Aneesh Kumar K.V, 2015/03/16
- [Qemu-devel] [PATCH 6/6] virtio: Fix memory leaks reported by Coverity, Aneesh Kumar K.V, 2015/03/16
- [Qemu-devel] [PATCH 4/6] fsdev/virtfs-proxy-helper: Fix improper use of negative value, Aneesh Kumar K.V, 2015/03/16
- [Qemu-devel] [PATCH 2/6] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv, Aneesh Kumar K.V, 2015/03/16
- Re: [Qemu-devel] [PULL] VirtFS update, Peter Maydell, 2015/03/16