Re: [Qemu-devel] [PATCH 1/9] virtio-gpu/2d: add hardware spec include file

[Max Reitz]

On 2015-03-13 at 05:47, Gerd Hoffmann wrote:
> This patch adds the header file with structs and defines for
> the virtio based gpu device.  Covers 2d operations only.
>
> Written by Dave Airlie and Gerd Hoffmann.
>
> Signed-off-by: Dave Airlie <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>   include/hw/virtio/virtgpu_hw.h | 203 +++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 203 insertions(+)
>   create mode 100644 include/hw/virtio/virtgpu_hw.h

There are some conflicts with the latest specification I was able to 
obtain 
(https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-gpu.pdf); for 
instance, the ordering of the fields in virtio_gpu_resp_display_info is 
different there, some GPU formats are different (but no conflict), and 
so on.

However, I guess this file will be pretty much the specification for the 
interface, so as long as it makes sense and it compiles, it's correct.

Reviewed-by: Max Reitz <address@hidden>