Re: [Qemu-devel] [PATCH] hw/usb: Include USB files only if necessary

[Thomas Huth]

On Tue, 17 Mar 2015 13:19:57 +0100
Gerd Hoffmann <address@hidden> wrote:

> On Di, 2015-03-17 at 13:05 +0100, Gerd Hoffmann wrote:
> > On Sa, 2015-03-14 at 06:33 +0100, Thomas Huth wrote:
> > > Boards that do not include an USB controller should not provide
> > > USB devices. However, when running "qemu-system-s390x -device help"
> > > for example, there's still a usb-hub, usb-kbd, usb-mouse and
> > > usb-tablet in the list of "supported" devices. Let's fix that
> > > by compiling and linking the USB files only if it's really
> > > necessary.
> > 
> > Added to usb queue.
> 
> Removed, fails to build.
> 
> Needs a complete rebuild due to the new CONFIG_USB option.  Hardly
> avoidable I guess.  But even with that done I still get this:
> 
>   LINK  lm32-softmmu/qemu-system-lm32
> ../hw/usb/redirect.o: In function `usbredir_bulk_packet':
> /home/kraxel/projects/qemu/hw/usb/redirect.c:1978: undefined reference
> to `usb_combined_input_packet_complete'

Oh, sorry, seems like I missed the "--enable-usb-redir" configure
option ... I'll have a look and rework my patch...

 Thomas