[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] omap_intc: convert ffs(3) to ctz32() in oma
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update() |
Date: |
Tue, 17 Mar 2015 15:58:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 17/03/2015 12:56, Stefan Hajnoczi wrote:
> + for (f = ctz32(level) + 1, i = f - 1, level >>= f - 1;
> + f != 33;
> + i += f, level >>= f) {
> p = s->bank[j].priority[i];
> if (p <= p_intr) {
> p_intr = p;
> sir_intr = 32 * j + i;
> }
> - f = ffs(level >> 1);
> + f = ctz32(level >> 1) + 1;
> }
Since it's 2.4, we might as well make the code nicer:
while (level != 0) {
i = ctz32(level);
p = s->bank[j].priority[i];
if (p <= p_intr) {
p_intr = p;
sir_intr = 32 * j + i;
}
level &= level - 1;
}
Paolo
- [Qemu-devel] [PATCH 0/7] Convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 1/7] bt-sdp: fix broken uuids power-of-2 calculation, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 6/7] os-win32: drop ffs(3) prototype, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 4/7] sd: convert sd_normal_command() ffs(3) call to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 3/7] Convert ffs() != 0 callers to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 7/7] checkpatch: complain about ffs(3) calls, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 5/7] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update(), Stefan Hajnoczi, 2015/03/17
- Re: [Qemu-devel] [PATCH 5/7] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update(),
Paolo Bonzini <=
- [Qemu-devel] [PATCH 2/7] Convert (ffs(val) - 1) to ctz32(val), Stefan Hajnoczi, 2015/03/17
- Re: [Qemu-devel] [PATCH 0/7] Convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/17