[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: Fix handling of STM (user) with r15
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: Fix handling of STM (user) with r15 in register list |
|
Date: |
Tue, 17 Mar 2015 17:26:14 +0000 |
On 17 March 2015 at 17:24, Greg Bellows <address@hidden> wrote:
> On Tue, Mar 10, 2015 at 12:18 PM, Peter Maydell
> <address@hidden> wrote:
>> The A32 encoding of LDM distinguishes LDM (user) from LDM (exception
>> return) based on whether r15 is in the register list. However for
>> STM (user) there is no equivalent distinction. We were incorrectly
>> treating "r15 in list" as indicating exception return for both LDM
>> and STM, with the result that an STM (user) involving r15 went into
>> an infinite loop. Fix this; note that the value stored for r15
>> in this case is the current PC regardless of our current mode.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Greg Bellows <address@hidden>
Thanks for the review, though this got committed to master yesterday :-)
-- PMM