[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] ehci: fix segfault when hot-unplugging e
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] ehci: fix segfault when hot-unplugging ehci controller |
|
Date: |
Wed, 18 Mar 2015 09:23:49 +0100 |
On Mi, 2015-03-18 at 09:49 +0800, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> When hot-unplugging the usb controllers (ehci/uhci),
> we have to clean all resouce of these devices,
> involved registered reset handler. Otherwise, it
> may cause NULL pointer access and/or segmentation fault
> if we reboot the guest os after hot-unplugging.
>
> Let's hook up reset via DeviceClass->reset() and drop
> the qemu_register_reset() call. Then Qemu will register
> and unregister the reset handler automatically.
Fails "make check" (for aarch64). My guess is the sysbus variants lost
the reset hookup.
cheers,
Gerd