[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/8] aer: fix wrong check on expose aer tlp prefix lo
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 4/8] aer: fix wrong check on expose aer tlp prefix log |
Date: |
Wed, 18 Mar 2015 13:34:45 +0100 |
From: Chen Fan <address@hidden>
when specify TLP Prefix log as using pcie_aer_inject_error,
the TLP prefix log is always discarded. because the check
is incorrect, the End-End TLP Prefix Supported bit
(PCI_EXP_DEVCAP2_EETLPP) should be in Device Capabilities 2 Register.
Signed-off-by: Chen Fan <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/pci/pcie_aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
index 5a25c32..c7fad34 100644
--- a/hw/pci/pcie_aer.c
+++ b/hw/pci/pcie_aer.c
@@ -433,7 +433,7 @@ static void pcie_aer_update_log(PCIDevice *dev, const
PCIEAERErr *err)
}
if ((err->flags & PCIE_AER_ERR_TLP_PREFIX_PRESENT) &&
- (pci_get_long(dev->config + dev->exp.exp_cap + PCI_EXP_DEVCTL2) &
+ (pci_get_long(dev->config + dev->exp.exp_cap + PCI_EXP_DEVCAP2) &
PCI_EXP_DEVCAP2_EETLPP)) {
for (i = 0; i < ARRAY_SIZE(err->prefix); ++i) {
/* 7.10.12 tlp prefix log register */
--
MST
- [Qemu-devel] [PULL 0/8] pci, virtio bugfixes for 2.3, Michael S. Tsirkin, 2015/03/18
- [Qemu-devel] [PULL 1/8] virtio: validate the existence of handle_output before calling it, Michael S. Tsirkin, 2015/03/18
- [Qemu-devel] [PULL 4/8] aer: fix wrong check on expose aer tlp prefix log,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 2/8] virtio: Fix memory leaks reported by Coverity, Michael S. Tsirkin, 2015/03/18
- [Qemu-devel] [PULL 5/8] pcie_aer: fix typos in pcie_aer_inject_error comment, Michael S. Tsirkin, 2015/03/18
- [Qemu-devel] [PULL 8/8] pcie_aer: fix comment to match pcie spec, Michael S. Tsirkin, 2015/03/18
- [Qemu-devel] [PULL 3/8] pcie: correct mistaken register bit for End-End TLP Prefix Blocking, Michael S. Tsirkin, 2015/03/18
- [Qemu-devel] [PULL 7/8] pci: fix several trivial typos in comment, Michael S. Tsirkin, 2015/03/18
- [Qemu-devel] [PULL 6/8] aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register, Michael S. Tsirkin, 2015/03/18
- Re: [Qemu-devel] [PULL 0/8] pci, virtio bugfixes for 2.3, Peter Maydell, 2015/03/19