Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

[Michael S. Tsirkin]

On Wed, Mar 18, 2015 at 03:00:12PM +0100, Gerd Hoffmann wrote:
> This patch adds virtio-input support to qemu.  It brings a abstract
> base class providing core support, other classes can build on it to
> actually implement input devices.
> 
> virtio-input basically sends linux input layer events (evdev) over
> virtio.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>

Two questions before I looked at code:
- can you do a writeup for the virtio spec?
  might make it easier to review.
- does linux need to support this?
  if yes we'll eventually want to take
  the header from there.
  maybe split out guest/host ABI?
  also might be a good idea to make style there
  linux-compliant (e.g. no typedefs, add typedefs
  in another header).