[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls |
Date: |
Wed, 18 Mar 2015 22:51:47 +0000 |
On 18 March 2015 at 22:43, John Snow <address@hidden> wrote:
> Calling abs() on a uint32_t is a no-op, so remove it.
> clang 3.5.0 will not compile this if -Werror is set,
> throwing a -Wabsolute-value warning.
>
> Signed-off-by: John Snow <address@hidden>
This is probably the wrong fix (ie it silences the
warning rather than fixing the bug). See
http://patchwork.ozlabs.org/patch/447585/
thanks
-- PMM