Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls

[John Snow]

On 03/18/2015 06:51 PM, Peter Maydell wrote:
> On 18 March 2015 at 22:43, John Snow <address@hidden> wrote:
> > Calling abs() on a uint32_t is a no-op, so remove it.
> > clang 3.5.0 will not compile this if -Werror is set,
> > throwing a -Wabsolute-value warning.
> >
> > Signed-off-by: John Snow <address@hidden>
>
> This is probably the wrong fix (ie it silences the
> warning rather than fixing the bug). See
> http://patchwork.ozlabs.org/patch/447585/
>
> thanks
> -- PMM

Ah, I missed that there was another patch out there and a deeper bug. I 
thought this was a harmless abs() inclusion, but I didn't look too 
deeply at it.

I am fine with dropping this patch if a more comprehensive change is in 
the works, but the other three should still stand.

--js