[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 3/4] configure: silence glib unknown attribute __
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v3 3/4] configure: silence glib unknown attribute __alloc_size__ |
Date: |
Thu, 19 Mar 2015 15:01:36 -0400 |
The glib headers use GCC attributes. Unfortunately the __GNUC__ and
__GNUC_MINOR__ version macros are also defined by clang, but clang
doesn't support the same attributes as GCC.
clang 3.5.0 does not support the __alloc_size__ attribute:
https://github.com/llvm-mirror/clang/commit/c047507a9a79e89fc8339e074fa72822a7e7ea73
The following warning is produced:
gstrfuncs.h:257:44: warning: unknown attribute '__alloc_size__' ignored
[-Wunknown-attributes]
G_GNUC_MALLOC G_GNUC_ALLOC_SIZE(2);
gmacros.h:67:45: note: expanded from macro 'G_GNUC_ALLOC_SIZE'
#define G_GNUC_ALLOC_SIZE(x) __attribute__((__alloc_size__(x)))
This patch checks whether glib headers cause warnings and disables
-Wunknown-attributes if it is able to.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
configure | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/configure b/configure
index 9a0e4ef..fbcbf50 100755
--- a/configure
+++ b/configure
@@ -2792,6 +2792,18 @@ if ! $pkg_config --atleast-version=2.38 glib-2.0; then
glib_subprocess=no
fi
+# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
+cat > $TMPC << EOF
+#include <glib.h>
+int main(void) { return 0; }
+EOF
+if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then
+ if cc_has_warning_flag "-Wno-unknown-attributes"; then
+ glib_cflags="-Wno-unknown-attributes $glib_cflags"
+ CFLAGS="-Wno-unknown-attributes $CFLAGS"
+ fi
+fi
+
##########################################
# SHA command probe for modules
if test "$modules" = yes; then
--
2.1.0
- Re: [Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check, (continued)
[Qemu-devel] [PATCH v3 4/4] configure: Add workaround for ccache and clang, John Snow, 2015/03/19
[Qemu-devel] [PATCH v3 3/4] configure: silence glib unknown attribute __alloc_size__,
John Snow <=
[Qemu-devel] [PATCH v3 1/4] configure: handle clang -nopie argument warning, John Snow, 2015/03/19