[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED |
|
Date: |
Mon, 23 Mar 2015 12:55:26 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Alberto Garcia <address@hidden> writes:
> On Mon, Mar 23, 2015 at 10:20:31AM +0100, Markus Armbruster wrote:
[...]
>> Ignorant question: can "device" be ""? If yes, we should document
>> what that means, possibly in a separate patch.
>
> Yes it can be "", the purpose of the patch is precisely to expand the
> event with a new field that can identify the node in such cases.
>
> The only reason why it is not optional is to keep backward
> compatibility.
>
> But it's true that it can be clarified in the documentation, I can
> send a follow-up patch as soon as this one is merged.
Follow-up patch works for me.