[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property |
Date: |
Mon, 23 Mar 2015 14:19:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 23/03/2015 13:09, Peter Maydell wrote:
> > The only alternative for 2.3 is reverting the patch for sdhci-pci. I
> > certainly don't want "-drive if=sd -device sdhci-pci" to become ABI!
>
> What's wrong with that, incidentally? It's what I would have
> expected for connecting an SD card to sdhci-pci, given
> how the other SD controller devices work. (The only
> difference with sdhci-pci is it happens to be a
> pluggable device rather than hardwired into a board model.)
Usually, "-drive if=" options (apart from if=none) are only handled at
board creation time, and is not affected by -device. PCI devices use
"-device sdhci-pci,drive=xyz" to tie themselves to a -drive option.
Paolo
- [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Paolo Bonzini, 2015/03/21
- Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Markus Armbruster, 2015/03/23
- Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Markus Armbruster, 2015/03/23
- Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Paolo Bonzini, 2015/03/23
- Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Peter Crosthwaite, 2015/03/23
- Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Peter Maydell, 2015/03/23
- Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Paolo Bonzini, 2015/03/23
- Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property, Markus Armbruster, 2015/03/24