Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 23/03/2015 13:09, Peter Maydell wrote:
>> > The only alternative for 2.3 is reverting the patch for sdhci-pci.  I
>> > certainly don't want "-drive if=sd -device sdhci-pci" to become ABI!
>>
>> What's wrong with that, incidentally? It's what I would have
>> expected for connecting an SD card to sdhci-pci, given
>> how the other SD controller devices work. (The only
>> difference with sdhci-pci is it happens to be a
>> pluggable device rather than hardwired into a board model.)
>
> Usually, "-drive if=" options (apart from if=none) are only handled at
> board creation time, and is not affected by -device.  PCI devices use
> "-device sdhci-pci,drive=xyz" to tie themselves to a -drive option.

Yes.

In other words: realize() methods aren't supposed to go on fishing
expeditions for backends.  They should rely on their backend properties.

The disgusting way we implement if=scsi should serve as deterrent, not
as example to emulate.