Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

[Peter Maydell]

On 23 March 2015 at 15:01, Peter Crosthwaite
<address@hidden> wrote:
> On Mon, Mar 23, 2015 at 7:05 PM, Markus Armbruster <address@hidden> wrote:
>> If sd.c is common code rather than a device model in its own right,
>> perhaps SDState should be unboxed in SDHCIState, just like the FDrive
>> are unboxed in FDCtrl.  The "drive" property can then be connected
>> straight to SDState member blk.

> sd.c for me is definitely a device in its own right, and SDHCI is
> quite separate. We already have multiple SD controllers connecting to
> SD cards. Ideally, SD should be bussified (or the modern equivalient
> using Links).

Yes, I think sd.c is just the way it is because it was written
long before QOM was ever invented, and nobody's cared enough since
to QOM and qdevify it...

-- PMM