Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

[Lin Ma]

在 2015年03月23日 20:52, Andreas Färber 写道:
> Hi Lin,
>
> Am 23.03.2015 um 11:10 schrieb Lin Ma:
> > Add can_be_deleted callback, If it is not null and returns false,
> > The qmp_object_del won't delete the given object.
> >
> > Signed-off-by: Lin Ma <address@hidden>
> > ---
> >   include/qom/object.h | 12 ++++++++++++
> >   qmp.c                |  7 +++++++
> >   qom/object.c         | 12 ++++++++++++
> >   3 files changed, 31 insertions(+)
> Why am I not being CC'ed here as QOM maintainer? You can use
> scripts/get_maintainer.pl to assist you, or read MAINTAINERS file.
Really sorry about that.
> Also, when sending more than one patch, always include a cover letter
> for grouping.
Thanks for reminding.
> It further seems that this is the second version already, so you
> should've used --subject-prefix="PATCH v2" and included a change log in
> the cover letter.
>
> Cf. http://wiki.qemu-project.org/Contribute/SubmitAPatch
>
> Regards,
> Andreas
Because the patch v1 is a single patch and not generic, So I dropped it.
That's why I didn't used --subject-prefix here. But I'll add all the 
info & format that you mentioned in patch v3.

Thanks,
Lin