Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

[Stefan Hajnoczi]

On Thu, Dec 11, 2014 at 02:36:14PM +0100, Wolfgang Link wrote:
> this qmp command returns the current link state from the given nic
> this is impotent if the set_link failed or get an timeout.

s/impotent/important/

I don't understand the rationale for this patch:

set_link does not fail or time out asynchronously, and the caller
immediately knows whether set_link succeeded or failed.  So I think this
command is not strictly necessary as implied by the commit description,
but it is useful if the QMP client wishes to query the current link
status.

> +SQMP
> +get_link_status
> +--------
> +
> +Get the link status of a network adapter.
> +
> +Arguments:
> +
> +- "name": network device name (json-string)
> +
> +Example:
> +
> +-> { "execute": "set_link", "arguments": { "name": "e1000.0" } }
> +<- { "return": {1} }
> +EQMP

Please add a query-link-status command.  All QMP commands that fetch
data are called query-*.

pgpcfGhimVd6L.pgp
Description: PGP signature