[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-ppc: gdbstub: Add VSX support
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-ppc: gdbstub: Add VSX support |
|
Date: |
Tue, 24 Mar 2015 10:57:36 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 24.03.15 10:50, Anton Blanchard wrote:
> Hi Alex,
>
>> On 24.03.15 09:59, Anton Blanchard wrote:
>>> Add the XML and functions to get and set VSX registers.
>>
>> Awesome, thanks. Have you verified that this works for LE as well as
>> BE guests?
>
> Unfortunately all our XML gdbstub routines have endian issues (FPU,
> Altivec and now VMX). I only caught that the other day.
>
> I can work on reusing maybe_bswap_register() from gdbstub.c.
Ouch. So I think we should fix the endianness issues for 2.3 (which is
in rc right now), but enable VMX for 2.4 since it's really a new feature.
Would you mind to work on and send at least the endian fixes reasonably
soon, so that we can still get them into the release?
Thanks a lot,
Alex