Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

[Stefan Berger]

On 03/23/2015 10:20 PM, Xu, Quan wrote:
> > -----Original Message-----
> > From: Stefan Berger [mailto:address@hidden
> > Sent: Tuesday, March 24, 2015 4:01 AM
> > To: Xu, Quan; Ian Campbell
> > Cc: address@hidden; address@hidden;
> > address@hidden; address@hidden
> > Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen
> > stubdom vTPM for HVM virtual machine
> >
> > On 03/23/2015 08:03 AM, Xu, Quan wrote:
> > > > -----Original Message-----
> > > > From: Stefan Berger [mailto:address@hidden
> > > > Sent: Monday, March 23, 2015 6:57 PM
> > > > To: Xu, Quan; Ian Campbell
> > > > Cc: address@hidden; address@hidden;
> > > > address@hidden; address@hidden
> > > > Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom
> > > > vTPM for HVM virtual machine
> > > >
> > > > On 03/22/2015 09:47 PM, Xu, Quan wrote:
> > > > > > -----Original Message-----
> > > > > > From: Stefan Berger [mailto:address@hidden
> > > > > > Sent: Friday, March 20, 2015 7:44 PM
> > > > > > To: Ian Campbell; Xu, Quan
> > > > > > Cc: address@hidden; address@hidden;
> > > > > > address@hidden; address@hidden
> > > > > > Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom
> > > > > > vTPM for HVM virtual machine
> > > > > >
> > > > > > On 03/19/2015 08:56 AM, Ian Campbell wrote:
> > > > > > > On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote:
> > > > > > > > @@ -151,6 +152,8 @@ device_hardware_setup(void)
> > > > > > > >          esp_scsi_setup();
> > > > > > > >          megasas_setup();
> > > > > > > >          pvscsi_setup();
> > > > > > > > +    if (runningOnXen())
> > > > > > > > +        vtpm4hvm_setup();
> > > > > > > Is there anything which is actually Xen specific about the driver
> > > > > > > in tpm.[ch]? Would it be better to just probe for it, perhaps
> > > > > > > gates by a Kconfig option which enables TPM support.
> > > > > > I also think the probing should be done. That code can also be
> > > > > > recycled from what I posted earlier. It's gated by a Kconfig
> > > > > > option, so it doesn't
> > > > fill up the 128k ROM.
> > > > > >         Stefan
> > > > > Agree, I will do it ASAP.
> > > > I reposted v9 of my series of patches. I will probably post v10 today.
> > > > Please try that one then since these patches should cover Xen, QEMU
> > > > (using a driver that only I can test at the moment), and to some
> > > > extent bare metal system.
> > > >
> > > >
> > > >       Stefan
> > > Great!  Could you also archive v10 to your github?
> > > then I can also test it and go through these source code.
> > I put it here now:
> >
> > https://github.com/stefanberger/seabios-tpm
> >
> >       Stefan
> Thanks.
> MS windows guest VM are maybe tricky issues. In my early-stage SeaBios patch,
> I deal with TPM TCPA and SSDT in SeaBios, but MS windows guest VM is blue 
> screens(Linux guest virtual machines are working).
> It works when I deal with TPM TCPA and SSDT in hvmloader for Windows guest VM.

Can you be a bit more specific as to what gets it to work or which 
modifications you have to make in SeaBIOS to make it work?


   Stefan