[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes |
|
Date: |
Wed, 25 Mar 2015 00:40:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 25.03.2015 um 00:11 schrieb Max Filippov:
> On Wed, Mar 25, 2015 at 2:03 AM, François Revol <address@hidden> wrote:
>> On 24/03/2015 23:56, Max Filippov wrote:
>>> On Wed, Mar 25, 2015 at 1:26 AM, Andreas Färber <address@hidden> wrote:
>>>> Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV:
>>>>>
>>>>
>>>> Why convert from array to switch statement? It looks like a very
>>>> invasive change for no obvious reason.
>>>
>>> I'd be interested to know the reason too, but I'm OK with either way.
>>
>> Maybe because negative array indices are usually a bad idea in C?
>
> Sounds like a good reason (:
True, but assumes that error codes are indeed negative.
AFAIU linking with -lposix_error_helper or so (-> configure/Makefile*)
may be an alternative, keeping errors POSIX-compliant in our code. I
don't recall the implementation details though...
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)