Re: [Qemu-devel] [PATCH for-2.3] arm: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

[Peter Maydell]

On 24 March 2015 at 21:24, Dirk Müller <address@hidden> wrote:
> Commit 0b183fc871:"memory: move mem_path handling to
> memory_region_allocate_system_memory" split memory_region_init_ram and
> memory_region_init_ram_from_file. Also it moved mem-path handling a step
> up from memory_region_init_ram to memory_region_allocate_system_memory.
>
> Therefore for any board that uses memory_region_init_ram directly,
> -mem-path is not supported.
>
> Fix this by replacing memory_region_init_ram with
> memory_region_allocate_system_memory.
>
> Signed-off-by: Dirk Mueller <address@hidden>
> ---
>  hw/arm/cubieboard.c   |  5 ++---
>  hw/arm/digic_boards.c |  3 +--
>  hw/arm/exynos4210.c   | 12 ++++++------
>  hw/arm/highbank.c     |  2 +-
>  hw/arm/integratorcp.c |  4 ++--
>  hw/arm/kzm.c          |  3 +--
>  hw/arm/musicpal.c     |  5 ++---
>  hw/arm/omap1.c        |  7 ++++---
>  hw/arm/omap2.c        |  6 +++---
>  hw/arm/realview.c     | 10 ++++------
>  hw/arm/strongarm.c    |  7 ++++---
>  hw/arm/versatilepb.c  |  5 ++---
>  hw/arm/vexpress.c     | 10 ++++------
>  hw/arm/virt.c         |  5 ++---
>  hw/arm/xilinx_zynq.c  |  5 ++---

So why do only the ARM boards get fixes here?
(Why did we allow ourselves to break half our boards
in commit 0b183fc871 in the first place?)

-- PMM