[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block: Switch to host monotonic clock for IO
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3] block: Switch to host monotonic clock for IO throttling |
Date: |
Wed, 25 Mar 2015 15:22:50 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 03/25 08:16, Alberto Garcia wrote:
> On Wed, Mar 25, 2015 at 10:42:32AM +0800, Fam Zheng wrote:
>
> > Block jobs are confusingly inconsistent between with and without
> > throttling: if user sets a bps limit, starts a block job, then stops
> > vm, the block job will not make any progress; in contrary, if user
> > unsets the bps limit, the block job will run normally.
>
> Wait, that's not what happens:
>
> a) If you start a job then stop the vm then the job will be
> completed immediately.
> b) If you stop the vm then start the job then it won't make any
> progress.
>
> This patch fixes b), but a) still happens.
>
Ah you're right, I put the order wrong. I'v just started looking at issue a).
I'll fix the text.
Fam