Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

[Chen, Tiejun]

On 2015/3/25 18:32, Ian Campbell wrote:
> On Wed, 2015-03-25 at 09:10 +0800, Chen, Tiejun wrote:
>
> > +But when given as a string the B<gfx_passthru> option describes the type
> > +of device to enable. Not this behavior is only supported with upstream
>
> "Note" and "the upstream..."

Fixed.

> > +=item "igd"
> > +
> > +Enables graphics device PCI passthrough but force set the type of device
> > +with the Intel Graphics Device.
>
> "but force set the type" doesn't scan very well. "... forcing the type
> of device to Intel Graphics Device" works I think.

Fine to me as well.

> > I understand what you mean but that table just includes IGDs existed on
> > BDW and HSW. Because in the case of qemu upstream we're just covering
> > these platforms, and with our discussion we don't have any plan to add
> > those legacy platforms in the future. But qemu-xen-traditional still
> > covers those platforms. So I'm afraid its not good to check this with
> > that table as well.
>
> Hrm, OK. I suppose we can live with autodetect and igd both meaning igd
> and whoever adds a new type will have to remember to add a check for
> qemu-trad then.

When we really have to introduce a new type, this means we probably need 
to change something inside qemu codes. So a new type should just go into 
that table to support qemu upstream since now we shouldn't refactor 
anything in qemu-xen-traditional, right?

Thanks
Tiejun