[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v6 10/14] migration: Add the core code for decompressi
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-devel] [v6 10/14] migration: Add the core code for decompression |
Date: |
Thu, 26 Mar 2015 02:46:34 +0000 |
> > + qemu_mutex_lock(¶m->mutex);
> > + while (!param->start && !quit_decomp_thread) {
>
> start protected by param->mutex.
>
>
> > + qemu_cond_wait(¶m->cond, ¶m->mutex);
> > + pagesize = TARGET_PAGE_SIZE;
> > + if (!quit_decomp_thread) {
> > + /* uncompress() will return failed in some case, especially
> > + * when the page is dirted when doing the compression, it's
> > + * not a problem because the dirty page will be
> > retransferred
> > + * and uncompress() won't break the data in other pages.
> > + */
> > + uncompress((Bytef *)param->des, &pagesize,
> > + (const Bytef *)param->compbuf, param->len);
> > + }
> > + param->start = false;
> > + }
> > + qemu_mutex_unlock(¶m->mutex);
> > }
> >
> > return NULL;
> > @@ -1492,6 +1517,11 @@ void migrate_decompress_threads_join(void)
> > quit_decomp_thread = true;
> > thread_count = migrate_decompress_threads();
> > for (i = 0; i < thread_count; i++) {
> > + qemu_mutex_lock(&decomp_param[i].mutex);
> > + qemu_cond_signal(&decomp_param[i].cond);
> > + qemu_mutex_unlock(&decomp_param[i].mutex);
> > + }
> > + for (i = 0; i < thread_count; i++) {
> > qemu_thread_join(decompress_threads + i);
> > qemu_mutex_destroy(&decomp_param[i].mutex);
> > qemu_cond_destroy(&decomp_param[i].cond);
> > @@ -1508,7 +1538,23 @@ void migrate_decompress_threads_join(void)
> > static void decompress_data_with_multi_threads(uint8_t *compbuf,
> > void *host, int len)
> > {
> > - /* To be done */
> > + int idx, thread_count;
> > +
> > + thread_count = migrate_decompress_threads();
> > + while (true) {
> > + for (idx = 0; idx < thread_count; idx++) {
> > + if (!decomp_param[idx].start) {
>
> start not protected
Yes, it's incorrect, I will change this.
> > + memcpy(decomp_param[idx].compbuf, compbuf, len);
> > + decomp_param[idx].des = host;
> > + decomp_param[idx].len = len;
> > + start_decompression(&decomp_param[idx]);
> > + break;
> > + }
> > + }
> > + if (idx < thread_count) {
> > + break;
> > + }
> > + }
> > }
> >
> > static int ram_load(QEMUFile *f, void *opaque, int version_id)
- [Qemu-devel] [PATCH v6 0/14] migration: Add a new feature to do live migration, Liang Li, 2015/03/23
- [Qemu-devel] [v6 08/14] migration: Add the core code of multi-thread compression, Liang Li, 2015/03/23
- [Qemu-devel] [v6 03/14] migration: Add the framework of multi-thread decompression, Liang Li, 2015/03/23
- [Qemu-devel] [v6 11/14] migration: Add interface to control compression, Liang Li, 2015/03/23
- [Qemu-devel] [v6 04/14] qemu-file: Add compression functions to QEMUFile, Liang Li, 2015/03/23
- [Qemu-devel] [v6 13/14] migration: Add qmp commands to set and query parameters, Liang Li, 2015/03/23
- [Qemu-devel] [v6 10/14] migration: Add the core code for decompression, Liang Li, 2015/03/23
- [Qemu-devel] [v6 09/14] migration: Make compression co-work with xbzrle, Liang Li, 2015/03/23
- [Qemu-devel] [v6 14/14] migration: Add hmp interface to set and query parameters, Liang Li, 2015/03/23
- [Qemu-devel] [v6 06/14] arch_init: Add and free data struct for decompression, Liang Li, 2015/03/23
- [Qemu-devel] [v6 05/14] arch_init: Alloc and free data struct for compression, Liang Li, 2015/03/23
- [Qemu-devel] [v6 07/14] migration: Split save_zero_page from ram_save_page, Liang Li, 2015/03/23
- [Qemu-devel] [v6 12/14] migration: Use an array instead of 3 parameters, Liang Li, 2015/03/23
- [Qemu-devel] [v6 02/14] migration: Add the framework of multi-thread compression, Liang Li, 2015/03/23
- [Qemu-devel] [v6 01/14] docs: Add a doc about multiple thread compression, Liang Li, 2015/03/23