[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 6/6] target-arm: cpu.h document why env->spsr
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 6/6] target-arm: cpu.h document why env->spsr exists |
Date: |
Thu, 26 Mar 2015 17:26:32 +0000 |
On 23 March 2015 at 17:05, Alex Bennée <address@hidden> wrote:
> I was getting very confused about the duplication of state so wanted to
> make it explicit.
>
> Signed-off-by: Alex Bennée <address@hidden>
>
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 083211c..6dc1799 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -155,6 +155,11 @@ typedef struct CPUARMState {
> This contains all the other bits. Use cpsr_{read,write} to access
> the whole CPSR. */
> uint32_t uncached_cpsr;
> + /* The spsr is a alias for spsr_elN where N is the current
> + * exception level.
This comment is still wrong.
> It is provided for here so the TCG msr/mrs
> + * implementation can access one register.
...and this is wrong too.
> Care needs to be taken
> + * to ensure the banked_spsr[] is also updated.
> + */
> uint32_t spsr;
>
> /* Banked registers. */
I think it would be better to just drop this patch, really...
-- PMM
- [Qemu-devel] [PATCH v5 0/6] QEMU ARM64 Migration Fixes, Alex Bennée, 2015/03/23
- [Qemu-devel] [PATCH v5 6/6] target-arm: cpu.h document why env->spsr exists, Alex Bennée, 2015/03/23
- Re: [Qemu-devel] [PATCH v5 6/6] target-arm: cpu.h document why env->spsr exists,
Peter Maydell <=
- [Qemu-devel] [PATCH v5 1/6] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc), Alex Bennée, 2015/03/23
- [Qemu-devel] [PATCH v5 4/6] target-arm: kvm64 sync FP register state, Alex Bennée, 2015/03/23
- [Qemu-devel] [PATCH v5 5/6] target-arm: kvm64 fix save/restore of SPSR regs, Alex Bennée, 2015/03/23
- [Qemu-devel] [PATCH v5 2/6] target-arm: kvm: save/restore mp state, Alex Bennée, 2015/03/23
- [Qemu-devel] [PATCH v5 3/6] hw/intc: arm_gic_kvm.c restore config first, Alex Bennée, 2015/03/23