[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support |
Date: |
Fri, 27 Mar 2015 09:11:19 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 03/26 19:52, Alberto Garcia wrote:
> On Thu, Mar 26, 2015 at 07:24:54PM +0200, Alberto Garcia wrote:
>
> > - The creation/destruction of ThrottleTimers is now handled internally
> > when a BlockDriverState is added/removed from a group, since
> > there's not much point on keeping them separate. This also hides
> > the timer callbacks from the outside, which makes things a bit
> > nicer and easier for some of the other changes included in these
> > series.
>
> Hmm... this actually breaks the new test because now BDS are required
> to have an AioContext attached when they're added to a group, which
> doesn't happen in qtest:
>
> bdrv = bdrv_new();
> throttle_group_register_bs(bdrv, "bar");
>
> I'm unsure of how to proceed with this, I don't see a clear way to
> attach the AioContext here (unless I do bdrv->aio_context = ctx).
> Suggestions are welcome.
Use bdrv_attach_aio_context?
Fam
- [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support, Alberto Garcia, 2015/03/26
- [Qemu-devel] [PATCH 2/7] throttle: Add throttle group infrastructure, Alberto Garcia, 2015/03/26
- [Qemu-devel] [PATCH 1/7] throttle: Extract timers from ThrottleState into a separate structure, Alberto Garcia, 2015/03/26
- [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo, Alberto Garcia, 2015/03/26
- [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support, Alberto Garcia, 2015/03/26
- [Qemu-devel] [PATCH 5/7] throttle: acquire the ThrottleGroup lock in bdrv_swap(), Alberto Garcia, 2015/03/26
- [Qemu-devel] [PATCH 7/7] throttle: Update throttle infrastructure copyright, Alberto Garcia, 2015/03/26
- [Qemu-devel] [PATCH 3/7] throttle: Add throttle group infrastructure tests, Alberto Garcia, 2015/03/26
- Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support, Alberto Garcia, 2015/03/26
- Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support, Stefan Hajnoczi, 2015/03/30