[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNest
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests |
Date: |
Fri, 27 Mar 2015 10:52:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> In the testsuite, UserDefTwo and UserDefNested were identical
> types other than the member names. Reduce code duplication by
> having just one type, and choose names that also favor reuse.
> This will also make it easier for a later patch to get rid of
> inline nested types in QAPI; it means that the type is now boxed
> instead of unboxed in C code, but has no difference to the QMP
> wire protocol.
I can't see a change from boxed to unboxed in this patch. Does the
remark apply to the elimination of nested types? If yes, it's premature
here.
> When touching code to add new allocations, also
> convert existing allocations to consistently prefer typesafe
> g_new0 over g_malloc0.
I can't see any change from g_malloc0() to g_new0(). Is this stale?
>
> Ensure that 'make check-qapi-schema check-unit' still passes.
>
> Signed-off-by: Eric Blake <address@hidden>
- Re: [Qemu-devel] [PATCH v5 21/28] qapi: Require valid names, (continued)
Re: [Qemu-devel] [PATCH v5 21/28] qapi: Require valid names, Markus Armbruster, 2015/03/27
Re: [Qemu-devel] [PATCH v5 21/28] qapi: Require valid names, Markus Armbruster, 2015/03/29
[Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in query-pci, Eric Blake, 2015/03/24
[Qemu-devel] [PATCH v5 28/28] qapi: Drop support for inline nested types, Eric Blake, 2015/03/24
[Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests, Eric Blake, 2015/03/24
- Re: [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests,
Markus Armbruster <=
[Qemu-devel] [PATCH v5 25/28] qapi: Drop tests for inline nested structs, Eric Blake, 2015/03/24
Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs, Markus Armbruster, 2015/03/27
Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs, Markus Armbruster, 2015/03/29