qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize
Date: Sun, 29 Mar 2015 09:30:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 28/03/2015 19:58, Michael S. Tsirkin wrote:
>> > +void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize, Error 
>> > **errp)
>> > +{
>> > +    assert(mr->terminates);
> Why? Does "terminates" guarantee that ram_addr
> is valid? In any case, I think this needs a comment.

More or less, but not really; I was just cutting/pasting it from other
functions that use ram_addr.  I will clean it up.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]