qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usag


From: Andreas Färber
Subject: [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage
Date: Sun, 29 Mar 2015 19:53:15 +0200

Hello Markus et al.,

This series attempts to fix the -device pc87312 issues you reported.

I can't add alias properties for devices that don't get created before realize.
Therefore this involves moving code for various ISA devices, to enable us
to initialize the objects early for alias properties and realizing them
as part of the composite device once the configuration is known, also fixing
error propagation while at it. Probably needs a further iteration.

Yes, it's terribly invasive, that's why the code was as it is.
But the code movements are quite trivial, as long as no in-air conflicts occur.

A follow-up would be to respin my old ISA enabled/disabled series to allow
inactive ISADevices sitting on an ISABus.

Regards,
Andreas

Cc: Markus Armbruster <address@hidden>
Cc: Hervé Poussineau <address@hidden>
Cc: address@hidden
Cc: address@hidden
Cc: John Snow <address@hidden>

Andreas Färber (8):
  parallel: Factor out header for ISAParallelState struct
  pc87312: Create isa-parallel in-place and add alias par0-chardev
    property
  serial: Move ISASerialState to header
  pc87312: Create UARTs in-place and add alias properties
  fdb: Move FDCtrlISABus to header
  pc87312: Create FDC in-place
  ide: Move ISAIDEState to header
  pc87312: Create IDE in-place

 hw/block/fdc.c             |  87 -----------------------
 hw/char/parallel.c         |  30 +-------
 hw/char/serial-isa.c       |  12 ----
 hw/ide/internal.h          | 155 ----------------------------------------
 hw/ide/isa.c               |  13 ----
 hw/isa/pc87312.c           | 107 ++++++++++++++++------------
 hw/ppc/prep.c              |  33 +++++++++
 include/hw/block/fdc.h     |  88 +++++++++++++++++++++++
 include/hw/char/parallel.h |  62 ++++++++++++++++
 include/hw/char/serial.h   |  14 ++++
 include/hw/ide.h           | 173 +++++++++++++++++++++++++++++++++++++++++++++
 include/hw/isa/pc87312.h   |  23 +++---
 12 files changed, 442 insertions(+), 355 deletions(-)
 create mode 100644 include/hw/char/parallel.h

-- 
2.1.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]