[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.3 3/6] ide: there is only one data port
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH for-2.3 3/6] ide: there is only one data port |
Date: |
Mon, 30 Mar 2015 13:45:15 +0200 |
IDE PIO data must be written, for example, at 0x1f0. You cannot
do word or dword writes to 0x1f1..0x1f3 to access the data register.
Adjust the ide_portio_list accordingly.
Cc: John Snow <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/ide/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index a895fd8..fcb9080 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2436,8 +2436,8 @@ void ide_init2(IDEBus *bus, qemu_irq irq)
static const MemoryRegionPortio ide_portio_list[] = {
{ 0, 8, 1, .read = ide_ioport_read, .write = ide_ioport_write },
- { 0, 2, 2, .read = ide_data_readw, .write = ide_data_writew },
- { 0, 4, 4, .read = ide_data_readl, .write = ide_data_writel },
+ { 0, 1, 2, .read = ide_data_readw, .write = ide_data_writew },
+ { 0, 1, 4, .read = ide_data_readl, .write = ide_data_writel },
PORTIO_END_OF_LIST(),
};
--
2.3.4
- [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 3/6] ide: there is only one data port,
Paolo Bonzini <=
- [Qemu-devel] [PATCH for-2.3 2/6] gus: clean up MemoryRegionPortio, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 4/6] ioport: remove wrong comment, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 5/6] ioport: loosen assertions on emulation of 16-bit ports, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 6/6] ioport: reserve the whole range of an I/O port in the AddressSpace, Paolo Bonzini, 2015/03/30
- Re: [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes, Mark Cave-Ayland, 2015/03/31