qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] ppc vga output breakage since commit c3c1bb99


From: Paolo Bonzini
Subject: Re: [Qemu-devel] ppc vga output breakage since commit c3c1bb99
Date: Mon, 30 Mar 2015 13:47:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 30/03/2015 13:45, Peter Crosthwaite wrote:
> Can the address_space_translate_address() length clamp be made
> conditional on non-MMIO access as the RC fix? I submitted
> c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 as I think its the right
> thing to do regardless of memory type, but in reality it only fixes a
> bug I encountered with RAM memory regions. The original code ignores
> address_space_translate_internal() return-by-pointer length value
> absolutely and the new code uses it absolutely. Should we just if the
> whole thing, old vs new behaviour on MMIO vs non-MMIO?
> 
> Happy to submit that fixup if that's the accepted plan.

I submitted what I think is the right fix (sorry Mark for misspelling
your email address).  I think you're patch is correct, so I'd rather not
introduce hacks for the release; we can either revert it, or fix ioport.c.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]